Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alot: 0.8 -> 0.8.1 #70439

Merged
merged 1 commit into from Oct 5, 2019
Merged

alot: 0.8 -> 0.8.1 #70439

merged 1 commit into from Oct 5, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 5, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@oxzi oxzi requested a review from FRidh as a code owner October 5, 2019 08:29
@teto
Copy link
Member

teto commented Oct 5, 2019

@GrahamcOfBorg build alot

@teto
Copy link
Member

teto commented Oct 5, 2019

would you like to set yourself as maintainer ?

@oxzi
Copy link
Member Author

oxzi commented Oct 5, 2019

@teto I have added myself as a maintainer. We'll have to see how this works.

@teto teto merged commit d852d58 into NixOS:master Oct 5, 2019
@teto
Copy link
Member

teto commented Oct 5, 2019

thanks. I also use alot but I am reluctant to add myself to even more packages. feel free to ping me if necessary.

@oxzi oxzi deleted the alot-v0.8.1 branch October 5, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @teto