Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

act: init at 0.1.3 #70615

Closed
wants to merge 2 commits into from
Closed

act: init at 0.1.3 #70615

wants to merge 2 commits into from

Conversation

novoxd
Copy link
Contributor

@novoxd novoxd commented Oct 7, 2019

Motivation for this change

Add act tool https://github.com/nektos/act .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

P.S. This is my first package build and first pr to nixpkgs, sorry if something wrong.

Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message must be act: init at 0.1.3. Same as the PR title.

pkgs/tools/admin/act/default.nix Outdated Show resolved Hide resolved
@novoxd novoxd changed the title act: add act: init at 0.1.3 Oct 8, 2019
@novoxd novoxd requested a review from kalbasit October 8, 2019 09:37
@novoxd
Copy link
Contributor Author

novoxd commented Oct 8, 2019

The commit message must be act: init at 0.1.3. Same as the PR title.

Thanks for little guide how to. Pr fixed.

@Lassulus
Copy link
Member

getting this error on reviewing:

hash mismatch in fixed-output derivation '/nix/store/anr7nkf60q3wjj2mjxn4cfidaw2b3skv-act-0.1.3-go-modules':
  wanted: sha256:0g7j9ysvsh7k8sg5nkxmkqnsa0xl824hynfg6cbmdydmb4lvv9rq
  got:    sha256:1c8bx9jb14f70aihnjbzk1js110s9r4nkdfps27kphn65bw2pxn0
cannot build derivation '/nix/store/ny7rk6ckqbrj04p3lqjcyapa9hir2rqd-act-0.1.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lgws18r6l3hm64zjsky8kaqq5jimgcb9-env.drv': 1 dependencies couldn't be built

@novoxd
Copy link
Contributor Author

novoxd commented Nov 1, 2019

@Lassulus fixed sha mismatch please recheck.

@kalbasit as I know you are working with go in nixpkgs (had read your post about buildGoModule). I found some issue while rebuilding this tool, I don't know is it an error or it something wrong in my system. Previously on 18.09 the build was fine and now after upgrade to 19.09 I have an error go: error loading module requirements. I googled this issue golang/go#31162 seems like related. Form stakoverflow link looks like some problems in new go version with old packages. I am not so familiar with go and its ecosystem so I cant determine what is the error and where it happened, so need some help.

nix-build -E 'with import <nixpkgs> {}; callPackage ./default.nix {}'
these derivations will be built:
  /nix/store/4ahav8mgks3nmjkpgypvrrbd3isigxg8-act-0.1.3-go-modules.drv
  /nix/store/hnq4f3p1b5fbq20nwkglvgw8v593xja5-act-0.1.3.drv
building '/nix/store/4ahav8mgks3nmjkpgypvrrbd3isigxg8-act-0.1.3-go-modules.drv'...
unpacking sources
unpacking source archive /nix/store/i7sn1mplclhcslx3jr4qbjp4335l80x4-source
source root is source
patching sources
configuring
building
go: finding github.com/opencontainers/image-spec v1.0.1
go: finding github.com/actions/workflow-parser v1.0.0
...
go: finding google.golang.org/genproto v0.0.0-20190128161407-8ac453e89fca
go: error loading module requirements
builder for '/nix/store/4ahav8mgks3nmjkpgypvrrbd3isigxg8-act-0.1.3-go-modules.drv' failed with exit code 1
cannot build derivation '/nix/store/hnq4f3p1b5fbq20nwkglvgw8v593xja5-act-0.1.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hnq4f3p1b5fbq20nwkglvgw8v593xja5-act-0.1.3.drv' failed

@Lassulus
Copy link
Member

Lassulus commented Nov 4, 2019

hmm, seems a little cursed here

hash mismatch in fixed-output derivation '/nix/store/0s7bi65pmgf5dzyn5iapa3mgmm8z89kc-act-0.1.3-go-modules':
  wanted: sha256:1c8bx9jb14f70aihnjbzk1js110s9r4nkdfps27kphn65bw2pxn0
  got:    sha256:00d0wjnr5y3bl95lma8sdwvqqs7fd0k43azawp1kb29kqnrlismg

@novoxd
Copy link
Contributor Author

novoxd commented Nov 5, 2019

hmm, seems a little cursed here

@Lassulus That is really strange, I changed the sha in last commit 2742abc . Maybe you did not pull last changes, or some other human-like error ? Can we call someone 3rd to reproduce this? Btw, do you use 19.09 (updated reasonably getting some strange bugs with packets like python pip ) ?

@Lassulus
Copy link
Member

I'm testing it with nix-review from unstable. the last hash mismatch was the source file, the new one is about the go-modules. so I guess there is another mismatch which is not apparent on your system?

@novoxd
Copy link
Contributor Author

novoxd commented Nov 22, 2019

Foud that build not passing because of one of the dependencies no more present. The https://github.com/actions/workflow-parser with 404, seems GitHub changing their location of action repository, and code in master of act is not fixed about this. So, to pass build need to wait for act developers, when they will fix dependencies. @kalbasit @Lassulus what to do with pr - close or keep open?

@Lassulus
Copy link
Member

if its gonna be a new release, maybe its easier to close this PR and create a new PR with the new version?

@novoxd novoxd mentioned this pull request Dec 27, 2019
10 tasks
@jonringer
Copy link
Contributor

closed in favor of #76536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants