-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
act: init at 0.1.3 #70615
act: init at 0.1.3 #70615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message must be act: init at 0.1.3
. Same as the PR title.
Thanks for little guide how to. Pr fixed. |
getting this error on reviewing:
|
@Lassulus fixed sha mismatch please recheck. @kalbasit as I know you are working with go in nixpkgs (had read your post about buildGoModule). I found some issue while rebuilding this tool, I don't know is it an error or it something wrong in my system. Previously on 18.09 the build was fine and now after upgrade to 19.09 I have an error
|
hmm, seems a little cursed here
|
@Lassulus That is really strange, I changed the sha in last commit 2742abc . Maybe you did not pull last changes, or some other human-like error ? Can we call someone 3rd to reproduce this? Btw, do you use 19.09 (updated reasonably getting some strange bugs with packets like python pip ) ? |
I'm testing it with nix-review from unstable. the last hash mismatch was the source file, the new one is about the go-modules. so I guess there is another mismatch which is not apparent on your system? |
Foud that build not passing because of one of the dependencies no more present. The https://github.com/actions/workflow-parser with 404, seems GitHub changing their location of action repository, and code in master of act is not fixed about this. So, to pass build need to wait for act developers, when they will fix dependencies. @kalbasit @Lassulus what to do with pr - close or keep open? |
if its gonna be a new release, maybe its easier to close this PR and create a new PR with the new version? |
closed in favor of #76536 |
Motivation for this change
Add act tool https://github.com/nektos/act .
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)P.S. This is my first package build and first pr to nixpkgs, sorry if something wrong.