Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mojo-js: Use correct style for constants #19547

Merged
merged 1 commit into from Oct 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 7, 2019

Use CONSTANT_CASE for generated constants. Changes all instances that
used the incorrect case.

Bug: 1009251
Change-Id: I79b856996f543650b4cd20e329978936a12adeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842976
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704073}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Use CONSTANT_CASE for generated constants. Changes all instances that
used the incorrect case.

Bug: 1009251
Change-Id: I79b856996f543650b4cd20e329978936a12adeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842976
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704073}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants