Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.virtualBoxGuestAdditions: fix build #70618

Merged
merged 1 commit into from
Oct 7, 2019
Merged

linuxPackages.virtualBoxGuestAdditions: fix build #70618

merged 1 commit into from
Oct 7, 2019
+2 −0

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Oct 7, 2019 •
edited
Loading

Motivation for this change

Fixes #70470

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @svanderburg

Sorry, something went wrong.

@lheckemann lheckemann force-pushed the vbox-guest-additions-fix branch from 288ee09 to 22011b0 Compare October 7, 2019 12:03
@ofborg ofborg bot requested a review from svanderburg October 7, 2019 12:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Oct 7, 2019
vcunat pushed a commit that referenced this pull request Oct 7, 2019
@lheckemann @vcunat
linuxPackages.virtualBoxGuestAdditions: fix build

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0e0ee08 
From #70618; fixes #70470.

(cherry picked from commit 22011b0)
fpletz
fpletz approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@vcunat
Copy link
Member

vcunat commented Oct 7, 2019

I tried to file a bug report upstream, but after persistent requests after things like my phone number I got fed up and gave up.

vcunat
vcunat approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see what to wait for. I already tested it on Hydra in 19.03.

vcunat added a commit that referenced this pull request Oct 7, 2019
@vcunat
Merge #70618: linuxPackages.virtualBoxGuestAdditions: fix build

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b7b8e1f
@vcunat vcunat merged commit 22011b0 into NixOS:master Oct 7, 2019
vcunat added a commit that referenced this pull request Oct 7, 2019
@vcunat
Merge #70618: linuxPackages.virtualBoxGuestAdditions: fix build
c922d88 
(cherry picked from commit b7b8e1f)
@globin globin deleted the vbox-guest-additions-fix branch October 7, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@globin globin

@vcunat vcunat

@svanderburg svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

virtualBox guest additions won't build *on Hydra*
4 participants
@lheckemann @vcunat @fpletz @globin