Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exercism: 3.0.11 -> 3.0.12 #70616

Merged
merged 1 commit into from Oct 15, 2019
Merged

exercism: 3.0.11 -> 3.0.12 #70616

merged 1 commit into from Oct 15, 2019

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Oct 7, 2019 •
edited by c0bw3b

Motivation for this change

A new version has been released a while ago: https://github.com/exercism/cli/tree/v3.0.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rbasso

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

@GrahamcOfBorg build exercism

c0bw3b
c0bw3b approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on my end too (nixos)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 15, 2019

Thank you for the contribution to nixpkgs @NobbZ :)

@c0bw3b c0bw3b merged commit 1299a42 into NixOS:master Oct 15, 2019
@NobbZ NobbZ deleted the exercism-3.0.12 branch October 17, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NobbZ @c0bw3b @Janik-Haag