Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argbash: init at 2.8.1 #70489

Merged
merged 3 commits into from Nov 7, 2019
Merged

argbash: init at 2.8.1 #70489

merged 3 commits into from Nov 7, 2019

Conversation

rencire
Copy link
Contributor

@rencire rencire commented Oct 5, 2019 •
edited

Motivation for this change

Add new package: argbash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

mmahut
mmahut reviewed Oct 5, 2019
View reviewed changes
pkgs/development/tools/misc/argbash/default.nix Outdated
{ stdenv, fetchFromGitHub, autoconf }:

stdenv.mkDerivation rec {
name = "argbash";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use pname.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@mmahut
Copy link
Member

mmahut commented Oct 5, 2019

@GrahamcOfBorg build argbash

@mmahut
Copy link
Member

mmahut commented Oct 6, 2019

@GrahamcOfBorg build argbash

nlewo
nlewo requested changes Oct 10, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you need to update the hash since it fails on ofBorg. Maybe you already have a derivation with this hash in your cache.

pkgs/development/tools/misc/argbash/default.nix
sha256 = "0jzfr2w5pza33mvw6hq6rm1vjgrfy95dp4421403jnji3ziwgf0w";
};

sourceRoot = "${src}/resources";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: i think a relative path is sufficient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried ./resources and resources and it didn't work. Seems like ${src} is required?

pkgs/development/tools/misc/argbash/default.nix Show resolved Hide resolved
@rencire rencire requested a review from nlewo November 3, 2019 06:16
@matthewbauer matthewbauer merged commit 5dc0c77 into NixOS:master Nov 7, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
@rencire @dtzWill
argbash: init at 2.8.1 (NixOS#70489)
3d4cb4d 
* argbash: init at 2.8.1

* changed name to pname

* updated sha256 hash

(cherry picked from commit 5dc0c77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rencire @mmahut @nlewo @matthewbauer