19.09 zhf mark broken #70645
Merged
19.09 zhf mark broken #70645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
requested review from
alyssais,
basvandijk,
edolstra,
Ericson2314,
FRidh,
infinisil,
joachifm,
matthewbauer,
nbp,
peti,
thoughtpolice,
ttuegel,
WilliButz and
zimbatm
as code owners
worldofpeace
reviewed
Oct 7, 2019
| @@ -87,5 +87,6 @@ rustPlatform.buildRustPackage rec { | |||
| license = licenses.gpl3; | |||
| maintainers = with maintainers; [ minijackson doronbehar ]; | |||
| platforms = platforms.all; | |||
| broken = true; | |||
jonringer
reviewed
Oct 7, 2019
| @@ -94,6 +94,7 @@ in { | |||
| description = "ZNC FiSH module"; | |||
| homepage = https://github.com/dctrwatson/znc-fish; | |||
| maintainers = [ stdenv.lib.maintainers.offline ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
znc backported fix cc25b7a
There was a problem hiding this comment.
Thanks, removed this broken-marking :)
| @@ -55,5 +55,6 @@ buildPythonPackage rec { | |||
| homepage = "https://github.com/santosjorge/cufflinks"; | |||
| license = licenses.mit; | |||
| maintainers = with maintainers; [ globin ]; | |||
| broken = true; | |||
| @@ -22,5 +22,6 @@ buildPythonPackage rec { | |||
| homepage = http://supervisord.org/; | |||
| license = licenses.free; # http://www.repoze.org/LICENSE.txt | |||
| maintainers = with maintainers; [ zimbatm ]; | |||
| broken = true; | |||
There was a problem hiding this comment.
this package builds on the branch
There was a problem hiding this comment.
oh, i forgot to be backport #70073, nevermind
There was a problem hiding this comment.
probably should backport @jonringer 👍
There was a problem hiding this comment.
We'll backport it on this branch
|
@GrahamcOfBorg build python3Packages.cufflinks pythonPackages.cufflinks zncModules.fish EDIT: oh yea, they won't build because they are already marked broken within the PR |
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: GNOME
ofborg
bot
added
2.status: merge conflict
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
6.topic: TeX
(cherry picked from commit 5d761d9)
disassembler
force-pushed
the
19.09-zhf-mark-broken
branch
from
bb284f5
to
f68f0a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @