Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spacegun: init at 0.3.3 #70526

Merged
merged 1 commit into from Dec 22, 2019
Merged

spacegun: init at 0.3.3 #70526

merged 1 commit into from Dec 22, 2019

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Oct 6, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/93

@bbigras
Copy link
Contributor

bbigras commented Dec 9, 2019

It builds. All 3 binaires run. I didn't test anything else since I don't use kubernetes.

@kampka
Copy link
Contributor Author

kampka commented Dec 19, 2019

@GrahamcOfBorg build spacegun

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/79

@nh2
Copy link
Contributor

nh2 commented Dec 22, 2019

I cannot test this myself, but merging on the base that @bbigras has reviewed it and that @kampka uses the same approach here as in his package matrix-appservice-slack.

@nh2 nh2 merged commit fd4dd7e into NixOS:master Dec 22, 2019
@kampka
Copy link
Contributor Author

kampka commented Dec 22, 2019

@nh2 @bbigras Thanks for reviewing!

@kampka kampka deleted the spacegun branch December 22, 2019 09:38
mweinelt
mweinelt reviewed Aug 27, 2020
View reviewed changes
pkgs/applications/networking/cluster/spacegun/default.nix

postInstall = ''
# Patch shebangs in node_modules, otherwise the webpack build fails with interpreter problems
patchShebangs --build "$out/lib/node_modules/spacegun/node_modules/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes errors like this:

sh: /nix/store/zay52n90397hcl16g4fp6dahiaiy9p0s-node_mini-media-player-v1.11.0/lib/node_modules/mini-media-player/node_modules/.bin/webpack: /usr/bin/env: bad interpreter: No such file or directory

I hope this improves the discoverability (searchengine) of this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kampka @nixos-discourse @bbigras @nh2 @mweinelt