[css-lists] Add list-style-type: <string> #19542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1841472
branch
11 times, most recently
from
2a1bec9
to
709b406
Compare
This patch extends the syntax of the list-style-type property to accept arbitrary string values in order to customize the marker contents. I have followed the same approach as https://crrev.com/c/879135 did for the display property. When a string is specified for list-style-type, the patch sets it to a special EListStyleType::kString, and the string is stored in an extra field. As a result of this split, list-style-type doesn't use as much auto generated code now, e.g. EListStyleType is not automatically generated. Intent to Implement and Ship: list-style-type: <string> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GojYpoeDbqc Spec: https://drafts.csswg.org/css-lists/#valdef-list-style-type-string Bug: 687946 TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-002.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-003.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-004.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005a.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005b.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-006.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-computed.html TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-valid.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001a.html TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001b.html This patch makes some ::marker tests in css-pseudo fail, but this is expected because ::marker has not been implemented yet. Change-Id: I5743b99bc1a8e66679235874623c82650860ea29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841472 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704563}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1841472
branch
from
709b406
to
3cadaf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the syntax of the list-style-type property to accept
arbitrary string values in order to customize the marker contents.
I have followed the same approach as https://crrev.com/c/879135 did for
the display property. When a string is specified for list-style-type,
the patch sets it to a special EListStyleType::kString, and the string
is stored in an extra field. As a result of this split, list-style-type
doesn't use as much auto generated code now, e.g. EListStyleType is not
automatically generated.
Intent to Implement and Ship: list-style-type: <string>
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GojYpoeDbqc
Spec: https://drafts.csswg.org/css-lists/#valdef-list-style-type-string
Bug: 687946
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-002.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-003.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-004.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005a.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-005b.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-006.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-computed.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-valid.html
TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001a.html
TEST=third_party/blink/web_tests/external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/list-style-type-string-001b.html
This patch makes some ::marker tests in css-pseudo fail, but this is
expected because ::marker has not been implemented yet.
Change-Id: I5743b99bc1a8e66679235874623c82650860ea29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841472
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704563}