Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter: init at 0.3.0 #70512

Closed
wants to merge 1 commit into from
Closed

formatter: init at 0.3.0 #70512

wants to merge 1 commit into from

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented Oct 6, 2019 •
edited

Motivation for this change

Add more curated apps from Elementary OS app store for Pantheon Desktop.

Currently not sure about the license, I opened a PR: Djaler/Formatter#55

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from worldofpeace October 6, 2019 09:58
@worldofpeace
Copy link
Contributor

The licenses in the preambles seem to be all mixed up
https://github.com/Djaler/Formatter/blob/master/src/Objects/DeviceFormatter.vala#L5
^ LGPL 2.0 Plus

And COPYING said GPL 2.0.

worldofpeace
worldofpeace suggested changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md mentions that it needs hfsprogs but it doesn't need it at build-time.

It actually needs various executable formatters to be in PATH
https://github.com/Djaler/Formatter/blob/master/src/Objects/DeviceFormatter.vala#L64
mkfs.ext4 etc.

What we prefer to do is to create patches like

for this.

A breakdown of how you can do this is like the following

  1. clone https://github.com/Djaler/Formatter
  2. checkout repo to the release tag
  3. patch calls to mkfs.* to placeholders like @fat@ so substituteAll can replace them.
    Here's the documentation on substituteAll:
  1. git diff @ > path_in_nixpkgs/fix-paths.patch
  2. Use the builder function in the expression

We basically do substituteAll on the patch which then gets applied.

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 6, 2019 •
edited

Note: don't patch in pkexec. We have to rely on that being installed because it needs to be setuid which aren't allowed in the nix store. On nixos, if you're using the polkit module, pkexec will be in path setuid at /run/wrappers/bin/pkexec.

@xiorcale
Copy link
Contributor Author

xiorcale commented Oct 6, 2019

Thanks for the breakdown (which, unlike substituteAll is very well documented 😉). It helped a lot.

@xiorcale
Copy link
Contributor Author

xiorcale commented Oct 6, 2019

The licenses in the preambles seem to be all mixed up
https://github.com/Djaler/Formatter/blob/master/src/Objects/DeviceFormatter.vala#L5
^ LGPL 2.0 Plus

And COPYING said GPL 2.0.

That is why I was a bit confused. I was hopping that my PR about the GPL 2.0 LICENSE.md would open the discussion about those mix up, but since he has merged it as is, I've assumed that GPL 2.0 would be fine.

This was referenced Oct 6, 2019
Open
Merged
@worldofpeace
Copy link
Contributor

The licenses in the preambles seem to be all mixed up
https://github.com/Djaler/Formatter/blob/master/src/Objects/DeviceFormatter.vala#L5
^ LGPL 2.0 Plus
And COPYING said GPL 2.0.

That is why I was a bit confused. I was hopping that my PR about the GPL 2.0 LICENSE.md would open the discussion about those mix up, but since he has merged it as is, I've assumed that GPL 2.0 would be fine.

I've asked for further clarification Djaler/Formatter#55 (comment).

Thanks for the breakdown (which, unlike substituteAll is very well documented wink). It helped a lot.

No problem 👍 I've referenced it at #65252, so until I get the moment to write the docs, maybe some one could discover that comment.

worldofpeace
worldofpeace suggested changes Oct 6, 2019
View reviewed changes
pkgs/applications/misc/formatter/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/formatter/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from worldofpeace October 6, 2019 20:29
worldofpeace
worldofpeace approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can format a device with the program.
We're just currently waiting on license clarification.

So mergers don't merge this until that's resolved.

@worldofpeace worldofpeace added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Oct 6, 2019
@worldofpeace
Copy link
Contributor

merged in b99357e with the corrected license.
Thanks @Kjuvi ✨

@worldofpeace worldofpeace mentioned this pull request Oct 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiorcale @worldofpeace