Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfortran: use version 8 by default to match our C and C++ compiler #70515

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

peti
Copy link
Member

@peti peti commented Oct 6, 2019

We recently updated to gcc 8.x, but our default Fortran compiler is still at
version 7.x. This causes trouble for all packages that mix C++ and Fortran
code, like R does.

@peti peti added 0.kind: enhancement Add something new 8.has: package (update) This PR updates a package to a newer version labels Oct 6, 2019
@peti peti force-pushed the t/update-to-gfortran8 branch from dd25f3f to 9b8ac21 Compare October 7, 2019 12:42

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
We recently updated to gcc 8.x, but our default Fortran compiler is still at
version 7.x. This causes trouble for all packages that mix C++ and Fortran
code, like R does.

Unfortunately, gfortran8 is marked broken on Darwin, so we cannot switch on
that platform yet:

 | $ nix-instantiate --arg nixpkg '{ outPath = ./.; revCount = 999999; shortRev = "peti"; }' ./pkgs/top-level/release.nix -A unstable --show-trace
 | [...]
 | while evaluating the attribute 'handled' at /home/simons/src/nixpkgs/pkgs/stdenv/generic/check-meta.nix:251:7:
 | while evaluating 'handleEvalIssue' at /home/simons/src/nixpkgs/pkgs/stdenv/generic/check-meta.nix:147:38, called from /home/simons/src/nixpkgs/pkgs/stdenv/generic/check-meta.nix:252:14:
 | Failed to evaluate gfortran-wrapper-8.3.0: «broken»: is marked as broken
@peti peti force-pushed the t/update-to-gfortran8 branch from 9b8ac21 to 982d859 Compare October 8, 2019 07:21
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Oct 8, 2019
@peti
Copy link
Member Author

peti commented Oct 8, 2019

@GrahamcOfBorg build openblas octopus openmolcas rPackages.RcppArmadillo

@NixOS NixOS deleted a comment from markuskowa Oct 8, 2019

Verified

This commit was signed with the committer’s verified signature. The key has been revoked.
joachifm Joachim F.
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Oct 8, 2019
@markuskowa
Copy link
Member

This causes quite a lot of rebuilds. Should this be based against staging?

@peti
Copy link
Member Author

peti commented Oct 9, 2019

No, going through staging seems unnecessary for less than 3000 rebuilds. That is not much.

@peti peti merged commit 5384da4 into NixOS:master Oct 9, 2019
@peti peti deleted the t/update-to-gfortran8 branch October 9, 2019 08:52
@veprbl veprbl mentioned this pull request Nov 25, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants