Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babeld: 1.9.0 -> 1.9.1 [19.09] #70657

Merged
merged 1 commit into from
Oct 11, 2019
Merged

babeld: 1.9.0 -> 1.9.1 [19.09] #70657

merged 1 commit into from
Oct 11, 2019
+2 −2

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 7, 2019

Motivation for this change

1.9.0 has a nasty bug that results in the babel daemon crashing. Therefore backport the bump to 1.9.1 from master.

Upstream CHANGELOG:

20 August 2019: babeld-1.9.1

  * Fixed a crash that could happen when unicast and RTT estimation are
    both enabled on an interface.  Thanks to Dave Taht.
  * Fixed compilation under BSD.  Thanks to Dave Taht.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @Fuuzetsu

Sorry, something went wrong.

@mweinelt
Copy link
Member Author

mweinelt commented Oct 7, 2019

FWIW: The eval breakage is unrelated to babeld.

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

jonringer
jonringer approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
executable seems to work
leaf package

[2 built, 1 copied (0.1 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70657
1 package were build:
babeld

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@r-ryantm @mweinelt
babeld: 1.9.0 -> 1.9.1

Unverified

The signing certificate or its chain could not be verified.
Certificate subject
Certificate issuer
CN sigstore-intermediate
O sigstore.dev
Learn about vigilant mode
845dc3f 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/babeld/versions

(cherry picked from commit 7d070a3)
@mweinelt mweinelt force-pushed the pr/19.09/babeld/1.9.1 branch from 5416ad8 to 845dc3f Compare October 10, 2019 08:44
@ofborg ofborg bot requested review from Fuuzetsu and fpletz October 10, 2019 08:58
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2019
@mweinelt
Copy link
Member Author

mweinelt commented Oct 10, 2019 •
edited
Loading

@jonringer checks pass now after rebasing.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build babeld

cc @Mic92 @lheckemann for backports

@flokli flokli merged commit e65ee46 into NixOS:release-19.09 Oct 11, 2019
@flokli
Copy link
Contributor

flokli commented Oct 11, 2019

Thanks!
@mweinelt, can you open a PR switching to pname for master?

@Mic92
Copy link
Member

Mic92 commented Oct 14, 2019

@flokli it already uses pname on master.

@flokli
Copy link
Contributor

flokli commented Oct 14, 2019

In that case, I never said anything :-)

@mweinelt
Copy link
Member Author

I addressed that in #70988.

@mweinelt mweinelt deleted the pr/19.09/babeld/1.9.1 branch January 19, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@Fuuzetsu Fuuzetsu

@fpletz fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @jonringer @flokli @Mic92 @r-ryantm