Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torchtext: init at 0.4.0 #70655

Closed
wants to merge 2 commits into from
Closed

torchtext: init at 0.4.0 #70655

wants to merge 2 commits into from

Conversation

vladmaraev
Copy link

@vladmaraev vladmaraev commented Oct 7, 2019 •
edited

Motivation for this change

Add torchtext: https://torchtext.readthedocs.io/en/latest/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jyp

@vladmaraev vladmaraev requested a review from FRidh as a code owner October 7, 2019 17:41
nlewo
nlewo requested changes Oct 9, 2019
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create two commits, one for adding yourself in the maintainer list (with a commit message such as: maintainers: add vladmaraev) and another one with the package?

Otherwise, looks good to me:)
And thanks for your contribution!

@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg build pythonPackages.torchtext python3Packages.torchtext

@vladmaraev
Copy link
Author

@nlewo thanks for your feedback, I have made a change that you requested.

@mmahut
Copy link
Member

mmahut commented Oct 11, 2019

@GrahamcOfBorg build pythonPackages.torchtext python3Packages.torchtext

@mmahut
Copy link
Member

mmahut commented Oct 11, 2019

@GrahamcOfBorg eval

@Lassulus
Copy link
Member

Lassulus commented Dec 8, 2019

fails to build for me:

builder for '/nix/store/1qz3pvwcsacyn6vn0ijml2zvzkw2y067-python3.7-torchtext-0.4.0.drv' failed with exit code 1; last 10 log lines:
      tests = self.loadTestsFromModule(package, pattern=pattern)
    File "/nix/store/3n4mnz8acknbgydi3dx15jmjns55avjf-python3.7-setuptools-41.6.0/lib/python3.7/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
      tests.append(self.loadTestsFromName(submodule))
    File "/nix/store/c2n0xp0j3nacr1l17lmrdzwp16ljsvll-python3-3.7.5/lib/python3.7/unittest/loader.py", line 191, in loadTestsFromName
      return self.loadTestsFromModule(obj)
    File "/nix/store/3n4mnz8acknbgydi3dx15jmjns55avjf-python3.7-setuptools-41.6.0/lib/python3.7/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
      tests.append(self.loadTestsFromName(submodule))
    File "/nix/store/c2n0xp0j3nacr1l17lmrdzwp16ljsvll-python3-3.7.5/lib/python3.7/unittest/loader.py", line 205, in loadTestsFromName
      test = obj()
  TypeError: batch() missing 2 required positional arguments: 'data' and 'batch_size'
cannot build derivation '/nix/store/3bdv4w02sh9cv3qc99s2c8b8h0z7gk2r-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 13 copied (27.7 MiB), 7.8 MiB DL]
error: build of '/nix/store/3bdv4w02sh9cv3qc99s2c8b8h0z7gk2r-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70655
1 package failed to build:
python37Packages.torchtext

@stale
Copy link

stale bot commented Jun 5, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2020
@infinisil
Copy link
Member

Not a lot of interest in this right now, closing for now

@infinisil infinisil closed this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vladmaraev @mmahut @Lassulus @infinisil @nlewo @Janik-Haag