Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromaprint: 1.3.2 -> 1.4.3 #70658

Merged
merged 2 commits into from
Oct 18, 2019
Merged

chromaprint: 1.3.2 -> 1.4.3 #70658

merged 2 commits into from
Oct 18, 2019
+9 −4

Conversation

dsg22
Copy link
Contributor

@dsg22 dsg22 commented Oct 7, 2019 •
edited
Loading

Changed upstream URL to GitHub. The latest release is not on BitBucket
and the web site points to GitHub.

Motivation for this change

Upstream version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ehmry

Sorry, something went wrong.

@dsg22
chromaprint: 1.3.2 -> 1.4.3
128fc2a 
Changed upstream URL to GitHub. The latest release is not on BitBucket
and the web site points to GitHub.
@ehmry
Copy link
Contributor

ehmry commented Oct 7, 2019

LGTM, thank you.

@samdoshi
Copy link
Contributor

samdoshi commented Oct 9, 2019

There is an existing PR for this: #60137

That one has a fix for Clementine which doesn't build with newer versions of chromaprint, though as it stands #60137 doesn't merge cleanly.

@c0bw3b
clementine: fix build w/ chromaprint 1.4+

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
330806a
@c0bw3b c0bw3b mentioned this pull request Oct 18, 2019
Closed
10 tasks
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 18, 2019

I reported clementine patch on @dsg22 branch

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 18, 2019

@GrahamcOfBorg build chromaprint acoustidFingerprinter python27Packages.pyacoustid python37Packages.pyacoustid

c0bw3b
c0bw3b approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can build all direct reverse-deps:

Result of nix-review pr 70658 1

13 package were build:
  • acoustidFingerprinter (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • chromaprint (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • clementine (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • grilo-plugins (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • gst_all_1.gst-plugins-bad (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • kid3 (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • libgroove (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • mixxx (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • picard (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • puddletag (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • python27Packages.pyacoustid (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • python37Packages.pyacoustid (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)
  • strawberry (gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,kdeApplications.dragon ,kdeApplications.kdenlive ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.phonon-backend-gstreamer ,libsForQt512.telepathy ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,winePackages.full ,xfce4-12.parole ,gnome3.yelp)

@c0bw3b c0bw3b merged commit 8b0f365 into NixOS:master Oct 18, 2019
@c0bw3b c0bw3b mentioned this pull request Oct 20, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsg22 @ehmry @samdoshi @c0bw3b