Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whois: 5.5.1 -> 5.5.2 #70613

Merged
merged 1 commit into from Oct 8, 2019
Merged

whois: 5.5.1 -> 5.5.2 #70613

merged 1 commit into from Oct 8, 2019

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Oct 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables seem to work
patch bump

[8 built, 5 copied (2.0 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70613
3 package were build:
firehol mkpasswd whois

@jonringer
Copy link
Contributor

@GrahamcOfBorg build whois

@jonringer jonringer merged commit c23f0c0 into NixOS:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants