Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notion: 3-2019050101 -> 4.0.0 #70610

Merged
merged 2 commits into from Mar 27, 2020
Merged

notion: 3-2019050101 -> 4.0.0 #70610

merged 2 commits into from Mar 27, 2020
+12 −7

Conversation

raboof
Copy link
Member

@raboof raboof commented Oct 7, 2019 •
edited

Notion 4 isn't released yet, but this prepares for that ;)

Motivation for this change

Update to the latest major version of Notion, which is proper LGPL again, has XFT support built-in without needing an external patch, a new set of keybindings, a greatly improved 'notionflux' REPL interface and many more improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tftio

@raboof raboof force-pushed the notion4 branch 2 times, most recently from db5c793 to e87bdac Compare October 9, 2019 21:31
@raboof raboof force-pushed the notion4 branch 2 times, most recently from cf46658 to 872de28 Compare October 29, 2019 20:25
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-screenshot-thread/1381/23

JohnAZoidberg
JohnAZoidberg requested changes Nov 7, 2019
View reviewed changes
pkgs/applications/window-managers/notion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/notion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/notion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/notion/default.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/notion/default.nix Outdated Show resolved Hide resolved
@raboof
Copy link
Member Author

raboof commented Nov 9, 2019

Thanks for the review! Updated the PR.

Still to do:

  • Actually release Notion 4.0.0
  • Update to that tag, drop the -unstable again
  • Verify notion -version works correctly
  • Undraft 🎉

@raboof raboof mentioned this pull request Jan 17, 2020
Merged
10 tasks
@ofborg ofborg bot removed the 6.topic: nixos label Jan 27, 2020
@ofborg ofborg bot requested a review from AndersonTorres January 27, 2020 13:04
@raboof raboof marked this pull request as ready for review March 17, 2020 20:08
@raboof
Copy link
Member Author

raboof commented Mar 17, 2020

4.0.0 is out so this is now ready 🎉

@raboof raboof changed the title Prepare for Notion 4 notion: 3-2019050101 -> 4.0.0 Mar 18, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tilling-window-manager-for-nixos/4205/21

@AndersonTorres
Copy link
Member

Yehoo!

@AndersonTorres AndersonTorres merged commit 79ed9e6 into NixOS:master Mar 27, 2020
@chreekat
Copy link
Contributor

Great!

@AndersonTorres
Copy link
Member

@raboof , by the way, just out of curiousity, there are plans to support notion running on Wayland?

@raboof
Copy link
Member Author

raboof commented May 22, 2020

out of curiousity, there are plans to support notion running on Wayland?

Short answer: no

Longer answer:

  • The Wayland model and the X11 model are quite different. While I would love to have something that looks and works like Notion on Wayland, I think we shouldn't try to support both from one codebase. Instead, I think a 'Notion on Wayland' should be a rewrite. I'm not even sure it should be written in C.
  • I think part of X's strength is its composability: you can mix-and-match the window manager, panel apps, task switching apps, screen capture and screenshot apps, etc etc. While Wayland's fundamentals seem quite stable, standardization for such integrations is happening but very much a work in progress. I don't think I want Notion to be anything but a window manager, so the question what to do/recommend for the other parts of the puzzle is not trivial.
  • I have much more ideas for project than time to do them, so currently I don't have any particular plans on working on this myself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@raboof @nixos-discourse @AndersonTorres @chreekat @JohnAZoidberg @Janik-Haag