Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocsigen_server: 2.11.0 → 2.15.0; ocamlPackages.ssl: 0.5.5 → 0.5.9 #70504

Merged
merged 1 commit into from Oct 13, 2019
Merged

ocamlPackages.ocsigen_server: 2.11.0 → 2.15.0; ocamlPackages.ssl: 0.5.5 → 0.5.9 #70504

merged 1 commit into from Oct 13, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 6, 2019 •
edited by maggesi

Motivation for this change

Compatibility with OCaml 4.08.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @maggesi (ssl) @FlorentBecker (ocsigen_server)

@vbgl
Copy link
Contributor Author

vbgl commented Oct 6, 2019

@GrahamcOfBorg build trv opa

@vbgl
Copy link
Contributor Author

vbgl commented Oct 6, 2019

The trv failure on darwin seems to be a regression.

@vbgl
Copy link
Contributor Author

vbgl commented Oct 6, 2019

@GrahamcOfBorg build ocamlPackages.cohttp-lwt-unix

@risicle
Copy link
Contributor

risicle commented Oct 6, 2019

Yes, on macos 10.13 I get a failure:

builder for '/nix/store/qp0k5ncjm3gy1f0cggw2iwk4x2yra6h9-ocaml-cohttp-0.19.3.drv' failed with exit code 2; last 10 log lines:
    "_X509_get_subject_name", referenced from:
        _client_verify_callback in libssl_stubs.a(ssl_stubs.o)
        _ocaml_ssl_get_subject in libssl_stubs.a(ssl_stubs.o)
  ld: symbol(s) not found for architecture x86_64
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  File "caml_startup", line 1:
  Error: Error during linking
  Command exited with code 2.
  E: Failure("Command ''/nix/store/sqr051rii5hmjsqwakqcfs6msyn30297-ocaml-4.02.3/bin/ocamlbuild' lib/cohttp.cma lib/cohttp.cmxa lib/cohttp.a lib/cohttp.cmxs top/cohttp_top.cma top/cohttp_top.cmxa top/cohttp_top.a top/cohttp_top.cmxs lwt-core/cohttp_lwt.cma lwt-core/cohttp_lwt.cmxa lwt-core/cohttp_lwt.a lwt-core/cohttp_lwt.cmxs lwt/cohttp_lwt_unix.cma lwt/cohttp_lwt_unix.cmxa lwt/cohttp_lwt_unix.a lwt/cohttp_lwt_unix.cmxs async/cohttp_async.cma async/cohttp_async.cmxa async/cohttp_async.a async/cohttp_async.cmxs bin/cohttp_server_async.native bin/cohttp_curl_async.native bin/cohttp_server_lwt.native bin/cohttp_proxy_lwt.native bin/cohttp_curl_lwt.native examples/async/hello_world.native examples/async/receive_post.native examples/doc/client_lwt.native examples/doc/server_lwt.native -tag debug -classic-display' terminated with error code 10")
  make: *** [Makefile:20: build] Error 1

@vbgl
Copy link
Contributor Author

vbgl commented Oct 7, 2019 •
edited

Thanks for testing. Would you have a hint on how to fix such linking issue?

Addition: this seems an upstream bug. Will try a workaround.

@vbgl
ocamlPackages.ocsigen_server: 2.11.0 → 2.15.0
4ba1825 
ocamlPackages.ssl: 0.5.5 → 0.5.9
@vbgl vbgl force-pushed the ocaml-ocsigen_server-2.15.0 branch from dac735a to 4ba1825 Compare October 7, 2019 15:43
@vbgl
Copy link
Contributor Author

vbgl commented Oct 7, 2019

@GrahamcOfBorg build ocamlPackages.cohttp-lwt-unix trv opa

maggesi
maggesi approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@maggesi maggesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on macOS.
Diff looks good.

@vbgl vbgl merged commit e1b9556 into NixOS:master Oct 13, 2019
@vbgl vbgl deleted the ocaml-ocsigen_server-2.15.0 branch October 13, 2019 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggesi maggesi maggesi approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @risicle @maggesi