surf: add run-time dependencies to PATH #70502
Merged
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #70410
Surf didn't work if it was run in a pure nix shell because then some of its run-time dependencies weren't found. To be even more extreme, I tested surf as follows:
If I noticed any complaints about commands that couldn't be found, I added them to
PATH
in the wrapper. Not sure if this is common practice, but as far as I understand, this is how applications should be wrapped.There might still be more run-time dependencies that are missing. I just tested some basic browsing. On the other hand, surf is so minimal that it has basically no other features than entering URL and following links. I tested both.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @