Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surf: add run-time dependencies to PATH #70502

Merged
merged 1 commit into from Oct 13, 2019

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Oct 6, 2019

Motivation for this change

Fix #70410

Surf didn't work if it was run in a pure nix shell because then some of its run-time dependencies weren't found. To be even more extreme, I tested surf as follows:

PATH="" `which surf`

If I noticed any complaints about commands that couldn't be found, I added them to PATH in the wrapper. Not sure if this is common practice, but as far as I understand, this is how applications should be wrapped.

There might still be more run-time dependencies that are missing. I just tested some basic browsing. On the other hand, surf is so minimal that it has basically no other features than entering URL and following links. I tested both.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jluttine
Copy link
Member Author

jluttine commented Oct 6, 2019

Forgot to cc maintainer @joachifm

@ofborg ofborg bot requested a review from joachifm October 6, 2019 07:55
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍
Verified that the correct entries are suffixed to PATH.

@worldofpeace worldofpeace merged commit 2f87a2f into NixOS:master Oct 13, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 24, 2019
surf: add run-time dependencies to PATH
(cherry picked from commit 2f87a2f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

surf: dmenu and xprop missing from PATH
4 participants