Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blcr package & nixos module #70503

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Remove blcr package & nixos module #70503

merged 2 commits into from
Oct 6, 2019
+3 −73

Conversation

joachifm
Copy link
Contributor

@joachifm joachifm commented Oct 6, 2019

Alternative to #70480

@joachifm
nixos/blcr: remove
923c449
@joachifm
linuxPackages.blcr: remove
83ffa14 
blcr is only supported for pre v4 kernels.
@joachifm joachifm requested a review from infinisil as a code owner October 6, 2019 06:12
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 6, 2019
teto
teto approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually I would wait for people to speak up but since this looks unlikely + for the sake of 0hf, I will merge now. We can revert later.

@teto teto merged commit 2a25b5c into NixOS:master Oct 6, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
@teto @dtzWill
Merge pull request NixOS#70503 from joachifm/feat/remove-blcr
840cfa1 
Remove blcr package & nixos module

(cherry picked from commit 2a25b5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joachifm @lheckemann @teto @worldofpeace