Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtpbfimageplugin: 1.4 -> 2.0 #70507

Merged
merged 1 commit into from
Nov 14, 2019
Merged

qtpbfimageplugin: 1.4 -> 2.0 #70507

merged 1 commit into from
Nov 14, 2019
+4 −4

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Oct 6, 2019 •
edited
Loading

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/lvgr9s7ywyhvrybrnic5q27m1fx5wy1n-qtpbfimageplugin-1.4
/nix/store/lvgr9s7ywyhvrybrnic5q27m1fx5wy1n-qtpbfimageplugin-1.4	 193.4M
$ nix path-info -Sh /nix/store/b8ykb9mpzn6jg62w4g1gsmc18vg3iy1w-qtpbfimageplugin-2.0
/nix/store/b8ykb9mpzn6jg62w4g1gsmc18vg3iy1w-qtpbfimageplugin-2.0	 193.5M

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 6, 2019
risicle
risicle approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review happy, macos 10.13 & non-nixos linux x86_64

c0bw3b
c0bw3b approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On nixos:

Result of nix-review pr 70507 1

1 package were build:
  • qtpbfimageplugin

@c0bw3b c0bw3b merged commit ab39782 into NixOS:master Nov 14, 2019
@sikmir sikmir deleted the qtpbfimageplugin branch November 14, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle

@c0bw3b c0bw3b

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @risicle @c0bw3b