Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustracer: 2.1.22 -> 2.1.27 #70506

Merged
merged 2 commits into from Oct 14, 2019
Merged

rustracer: 2.1.22 -> 2.1.27 #70506

merged 2 commits into from Oct 14, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 6, 2019 •
edited by veprbl

Motivation for this change

Fixes failing build on master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Resolves: #70948

@danieldk
Copy link
Contributor Author

danieldk commented Oct 6, 2019

Added a second commit that fixes the default RUST_SRC_PATH (which was empty).

@ofborg ofborg bot requested a review from jagajaga October 6, 2019 08:09
risicle
risicle approved these changes Oct 6, 2019
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review happy for me, macos 10.13, non-nixos linux x86_64

wykurz
wykurz approved these changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@wykurz wykurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@wykurz wykurz mentioned this pull request Oct 12, 2019
Closed
@danieldk
Copy link
Contributor Author

danieldk commented Oct 12, 2019 •
edited

@Mic92 I think you were the latest committer to make a larger change to this derivation, so I thought it would be good to ping you (don't know who else ;)). Would be nice if we could unbreak this package (IIRC it is also broken on 19.09).

@Mic92
Copy link
Member

Mic92 commented Oct 14, 2019

We actually reverted the rustc backport in 19.03 again. But this fix should be also backported in case we try it another time.

@Mic92 Mic92 merged commit 63746f6 into NixOS:master Oct 14, 2019
@Mic92 Mic92 mentioned this pull request Oct 14, 2019
Merged
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 15, 2019
@Mic92 @dtzWill
Merge pull request NixOS#70506 from danieldk/racer-2.1.27
9f70e8e 
rustracer: 2.1.22 -> 2.1.27
(cherry picked from commit 63746f6)
@danieldk danieldk deleted the racer-2.1.27 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wykurz wykurz wykurz approved these changes

@risicle risicle risicle approved these changes

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: update rustracer 2.1.22 --> 2.1.27
4 participants
@danieldk @Mic92 @wykurz @risicle