Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glfw: 3.2.1 -> 3.3 #70626

Merged
merged 1 commit into from Nov 7, 2019
Merged

glfw: 3.2.1 -> 3.3 #70626

merged 1 commit into from Nov 7, 2019

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Oct 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @MarcWeber

jonringer
jonringer approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[18 built, 71 copied (717.9 MiB), 87.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70626
11 package were build:
ccextractor embree2 glfw glslviewer goxel idrisPackages.glfw io kitty luxcorerender vcv-rack vlang

@jonringer
Copy link
Contributor

@GrahamcOfBorg build glfw

@Marqin
Copy link

Marqin commented Oct 8, 2019

@jonringer any ETA when this will land?

@jonringer
Copy link
Contributor

I just want to give some time for other maintainers to comment. I'm not super familiar with glfw

@Moredread
Copy link
Contributor

Moredread commented Oct 16, 2019 •
edited

vcv-rack overrides the glfw version, so this shouldn't cause a problem there. We might be able to switch to upstream again after this merges though.

@k0ral
Copy link
Contributor

k0ral commented Nov 7, 2019

I was about to contribute the same change when I noticed this pull-request.
Given that it's been open for a month now, with no reservations from reviewers, would-you-kindly consider merging it ? :)

@jonringer
Copy link
Contributor

really wish there was a !remindme 2 days functionality... too many PRs xD

jonringer
jonringer approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[26 built, 345 copied (4920.8 MiB), 787.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70626
11 package were build:
ccextractor embree2 glfw glslviewer goxel idrisPackages.glfw io kitty luxcorerender vcv-rack vlang

sorry for the long delay! :(

@jonringer jonringer merged commit 5f6f75f into NixOS:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Twey @jonringer @Marqin @Moredread @k0ral