Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elpi: 1.6.0 -> 1.7.0 #70629

Merged
merged 1 commit into from Oct 7, 2019
Merged

elpi: 1.6.0 -> 1.7.0 #70629

merged 1 commit into from Oct 7, 2019

Conversation

maggesi
Copy link
Contributor

@maggesi maggesi commented Oct 7, 2019

Motivation for this change

Update Elpi to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@maggesi
Copy link
Contributor Author

maggesi commented Oct 7, 2019

(It is a while since I contributed a change to Nixos / Nixpkgs. How this PR fits the guideline.)

@maggesi maggesi merged commit c70d7fa into NixOS:master Oct 7, 2019
@maggesi
Copy link
Contributor Author

maggesi commented Oct 7, 2019

@vbgl: Sorry I merged the PR by mistake!
Since my modification should be pretty innocent, I won't touch this now unless there is a problem.

@vbgl
Copy link
Contributor

vbgl commented Oct 7, 2019

No problem. Thanks for your contribution!

@vbgl vbgl mentioned this pull request Oct 16, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maggesi @vbgl