Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5.qtbase: Build all QPA backends by default #70550

Merged
merged 1 commit into from Oct 8, 2019
Merged

qt5.qtbase: Build all QPA backends by default #70550

merged 1 commit into from Oct 8, 2019

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 7, 2019 •
edited

Motivation for this change

It looks like there is no reason to disable any of these backends any more.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@adisbladis adisbladis changed the base branch from master to staging October 7, 2019 00:18
@ofborg ofborg bot requested review from bkchr, periklis and qknight October 7, 2019 00:36
ttuegel
ttuegel approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Did you check closure size?

@adisbladis
Copy link
Member Author

adisbladis commented Oct 8, 2019 •
edited

Did you check closure size?

@ttuegel Yes I did! The out output is increased by 2M and bin is increased by 1M with no extra runtime dependencies.

@adisbladis adisbladis merged commit 6137b83 into NixOS:staging Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@bkchr bkchr Awaiting requested review from bkchr

@periklis periklis Awaiting requested review from periklis

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @ttuegel