Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cups-filters: 1.25.0 -> 1.25.6 #70484

Merged
merged 1 commit into from Oct 5, 2019
Merged

cups-filters: 1.25.0 -> 1.25.6 #70484

merged 1 commit into from Oct 5, 2019

Conversation

marzipankaiser
Copy link
Contributor

Motivation for this change

Fixes #70483 for me

Things done

Updated version & hash for cups-filters

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build cups-filters

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 5, 2019 •
edited

@GrahamcOfBorg test printing

@worldofpeace
Copy link
Contributor

These are some very detailed changelogs

@worldofpeace worldofpeace merged commit eb9a358 into NixOS:master Oct 5, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing this @marzipankaiser ✨

@dasJ
Copy link
Member

dasJ commented Oct 6, 2019

@marzipankaiser Does this need backporting to 19.09?

@dasJ dasJ mentioned this pull request Oct 6, 2019
Closed
@worldofpeace
Copy link
Contributor

@dasJ I determined this was unneeded because it builds fine in 19.09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cups-filters fail to build
3 participants
@marzipankaiser @worldofpeace @dasJ