applet.interface.i2c_master: do write scanning before read scanning t… #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Oct 6, 2019
| @@ -237,19 +237,19 @@ def __init__(self, interface, logger): | |||
| # default address range: don't scan reserved I2C addresses | |||
| found = set() | |||
| for addr in addresses: | |||
| if write: | |||
There was a problem hiding this comment.
Maybe add a comment explaining the ordering?
…o reduce possible side-effects
electroniceel
force-pushed
the
i2c-scan
branch
from
ed2ff80
to
beaaba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o reduce possible side-effects
as discussed in #166