[LayoutNG] Fix line breaking when font-size: 0
#19541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes line breaking when break opportunities have
font-size: 0
.font-size: 0
makes all characters at position 0. Thisconfuses when |NGLineBreaker| needs to rewind, and tries to
find the break opportunity before the current one.
This patch fixes it by using |PreviousBreakOpportunity| in
such case.
Bug: 1006127
Change-Id: I449d6f8aaba4deccd458c5e077920b1a8bf79305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843991
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703753}