Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-cpp: 0.14.1 -> 0.15.0 #70584

Merged
merged 4 commits into from Oct 8, 2019
Merged

arrow-cpp: 0.14.1 -> 0.15.0 #70584

merged 4 commits into from Oct 8, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Oct 7, 2019 •
edited

Release page: https://arrow.apache.org/release/0.15.0.html
Blog post: https://arrow.apache.org/blog/2019/10/06/0.15.0-release/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @veprbl

@ofborg ofborg bot requested a review from veprbl October 7, 2019 07:26
@veprbl veprbl self-assigned this Oct 7, 2019
@veprbl
Copy link
Member

veprbl commented Oct 7, 2019

@GrahamcOfBorg build arrow-cpp python27Packages.pyarrow python37Packages.pyarrow
@GrahamcOfBorg build python27Packages.awkward python37Packages.awkward

jonringer
jonringer reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression in the pythonPackages.awkward package

[7 built (3 failed), 5 copied (4.2 MiB), 0.6 MiB DL]
error: build of '/nix/store/vlwq8acx8pmcjfih9shlgmqyc675dgkn-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70584
7 package failed to build:
python27Packages.awkward python27Packages.uproot python27Packages.uproot-methods python37Packages.awkward python37Packages.ibis-framework python37Packages.uproot python37Packages.uproot-methods

5 package were build:
arrow-cpp python27Packages.google_cloud_bigquery python27Packages.pyarrow python37Packages.google_cloud_bigquery python37Packages.pyarrow

@veprbl
Copy link
Member

veprbl commented Oct 8, 2019

@GrahamcOfBorg build arrow-cpp python27Packages.pyarrow python37Packages.pyarrow

(Issue with awkward array still needs to be resolved)

@tobim
Copy link
Contributor Author

tobim commented Oct 8, 2019

regression in the pythonPackages.awkward package

Thanks for catching that, I'll have a look.

@tobim
Copy link
Contributor Author

tobim commented Oct 8, 2019

Created an issue upstream: scikit-hep/awkward-0.x#203.
I suppose it should be ok to disable this test for the time being.

@tobim tobim requested a review from FRidh as a code owner October 8, 2019 09:59
@ofborg ofborg bot requested a review from costrouc October 8, 2019 10:13
@jonringer
Copy link
Contributor

I'm not convinced that disabling the tests is the right answer, sure the package builds now, but it might indicate that the package is now in an invalid state (can't actually use it)

@jonringer
Copy link
Contributor

We might want to wait for the awkward package to support arrow~=0.15.0

@tobim
Copy link
Contributor Author

tobim commented Oct 8, 2019

Consider the proposed fix in scikit-hep/awkward-0.x#204.
We might wait for the next release of awkward, but I don't know how long we'll have to wait for that.

@jonringer
Copy link
Contributor

could be a while depending on how the code is structured, and what assumptions were made about the arrow runtime

@veprbl
Copy link
Member

veprbl commented Oct 8, 2019

@GrahamcOfBorg build arrow-cpp python27Packages.pyarrow python37Packages.pyarrow
@GrahamcOfBorg build python27Packages.awkward python37Packages.awkward

@tobim
Copy link
Contributor Author

tobim commented Oct 8, 2019

https://github.com/scikit-hep/awkward-array/releases/tag/0.12.13 containing a fix was already released a couple hours ago. Should I bump the pkg up and drop the commit that disables that one test?

@jonringer
Copy link
Contributor

I would do the bump as part of this PR

@jonringer
Copy link
Contributor

you will need to rebase on top of currrent master git pull -r origin master

@veprbl veprbl removed their assignment Oct 8, 2019
@veprbl
Copy link
Member

veprbl commented Oct 8, 2019

@GrahamcOfBorg build arrow-cpp python27Packages.pyarrow python37Packages.pyarrow
@GrahamcOfBorg build python27Packages.awkward python37Packages.awkward

veprbl
veprbl approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux

1 package failed to build:
python37Packages.ibis-framework

11 package were build:
arrow-cpp python27Packages.awkward python27Packages.google_cloud_bigquery python27Packages.pyarrow python27Packages.uproot python27Packages.uproot-methods python37Packages.awkward python37Packages.google_cloud_bigquery python37Packages.pyarrow python37Packages.uproot python37Packages.uproot-methods

@veprbl veprbl merged commit 702f58f into NixOS:master Oct 8, 2019
@tobim tobim deleted the pkgs/arrow-cpp branch October 9, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @veprbl @jonringer