Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leap-motion: init at 2.3.1 #70522

Closed
wants to merge 2 commits into from
Closed

leap-motion: init at 2.3.1 #70522

wants to merge 2 commits into from

Conversation

fx-chun
Copy link
Member

@fx-chun fx-chun commented Oct 6, 2019

Motivation for this change

Adds support for the Leap Motion controller.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tilpner
tilpner suggested changes Oct 6, 2019
View reviewed changes
nixos/modules/hardware/leap-motion.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/leap-motion.nix Outdated Show resolved Hide resolved
pkgs/misc/leap-motion/default.nix Outdated Show resolved Hide resolved
@fx-chun fx-chun force-pushed the init/leap-motion branch 3 times, most recently from 7e09980 to ce9a0b9 Compare October 6, 2019 19:28
@fx-chun fx-chun requested a review from tilpner October 6, 2019 19:30
@fx-chun fx-chun requested a review from tilpner October 9, 2019 01:17
infinisil
infinisil requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works decently with my ancient leap motion! The binaries seem to have some weird occasional issues, but that's probably fine for a start.

pkgs/misc/leap-motion/default.nix
cp ./usr/bin/Recalibrate $out/bin
cp ./usr/bin/Visualizer $out/bin

cp ./usr/bin/Playground $out/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go to $out/bin as well?

nixos/modules/hardware/leap-motion.nix
wantedBy = [ "default.target" ];

serviceConfig = {
Type = "simple";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default, no need to specify it

nixos/modules/hardware/leap-motion.nix
Type = "simple";
Restart = "always";
ExecStart = "${pkgs.leap-motion}/bin/leapd";
KillSignal = "SIGKILL";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this the service is running as root which is not that great. Try using DynamicUser = true instead

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/misc/leap-motion/default.nix
Comment on lines +82 to +90
meta = {
homepage = https://www.leapmotion.com/;
description = "Core software for the Leap Motion";
license = stdenv.lib.licenses.unfree;
platforms = stdenv.lib.platforms.linux;
maintainers = [ stdenv.lib.maintainers.noneucat ];
};

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
homepage = https://www.leapmotion.com/;
description = "Core software for the Leap Motion";
license = stdenv.lib.licenses.unfree;
platforms = stdenv.lib.platforms.linux;
maintainers = [ stdenv.lib.maintainers.noneucat ];
};
}
meta = with lib; {
homepage = https://www.leapmotion.com/;
description = "Core software for the Leap Motion";
license = licenses.unfree;
platforms = platforms.linux;
maintainers = [ maintainers.noneucat ];
};
}

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity. Feel free to reopen the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@infinisil infinisil infinisil requested changes

@tilpner tilpner Awaiting requested review from tilpner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fx-chun @SuperSandro2000 @tilpner @infinisil