Resolution of Arnold's equation with minimal testing #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
reviewed
Oct 6, 2019
physics/euler_solver_body.hpp
Outdated
| Bivector<Variation<AngularMomentum>, PrincipalAxesFrame> const ṁ = | ||
| Commutator(m, ω) / Radian; | ||
|
|
||
| // If ṁ is constant in the principal axes frame, pick 𝒫ₜ = identity. |
There was a problem hiding this comment.
If m is constant, or If ṁ is 0.
But how is this correct? If 𝒫ₜ is the identity in coordinates, 𝒫ₜ(m_normalized) is e₃ (in ℬₜ) only if m_normalized is e₃ (in PrincipalAxesFrame); but m can be constant for at least 6 different values of m_normalized (±eᵢ in PrincipalAxesFrame), and for many values if some moments of inertia are equal.
eggrobin
reviewed
Oct 6, 2019
| if (m.x < AngularMomentum()) { | ||
| B₁₃_ = -B₁₃_; | ||
| σB₁₃_ = -B₁₃_; |
There was a problem hiding this comment.
Add a TODO to investigate the behaviour with respect to nothing's sign bit.
eggrobin
approved these changes
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.