Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gleam #71432

Closed
wants to merge 4 commits into from
Closed

Gleam #71432

wants to merge 4 commits into from

Conversation

NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Oct 20, 2019

Motivation for this change

Make the gleam compiler available via nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Arch Linux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc ?

Lassulus
Lassulus reviewed Nov 17, 2019
View reviewed changes
maintainers/maintainer-list.nix
@@ -3974,12 +3974,12 @@
githubId = 34086;
name = "Marc Weber";
};
marenz = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

@Lassulus
Copy link
Member

can you make 2 commits out of this? one for the maintainer addition and one for the package. the commit messages should be:
maintainers: add nobbz
gleam: init at 0.4.1

@Br1ght0ne Br1ght0ne mentioned this pull request Dec 17, 2019
Merged
10 tasks
Br1ght0ne added a commit to Br1ght0ne/nixpkgs that referenced this pull request Dec 18, 2019
@Br1ght0ne @NobbZ
gleam: init at 0.5.0
a866b61 
Close NixOS#71432.

Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
jonringer pushed a commit that referenced this pull request Dec 18, 2019
@Br1ght0ne @NobbZ
gleam: init at 0.5.0
aed6f88 
Close #71432.

Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
mgttlinger pushed a commit to mgttlinger/nixpkgs that referenced this pull request Dec 19, 2019
@Br1ght0ne @NobbZ @mgttlinger
gleam: init at 0.5.0
b4559fc 
Close NixOS#71432.

Co-authored-by: Norbert Melzer <NobbZ@users.noreply.github.com>
@NobbZ NobbZ deleted the gleam branch November 22, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NobbZ @Lassulus