Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: Not possible to use the up/down keys in the console #7784

Closed
JGRennison opened this issue Oct 20, 2019 · 3 comments · Fixed by #7815
Closed

SDL2: Not possible to use the up/down keys in the console #7784

JGRennison opened this issue Oct 20, 2019 · 3 comments · Fixed by #7815

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Since 2d27e8e

Expected result

In the console, pressing the up/down keys selects items from the command history

Actual result

In the console, pressing the up/down keys has no action

Steps to reproduce

Open the console and press the up or down keys once the history has some items

A possibly non-ideal fix is: JGRennison/OpenTTD-patches@299becb
@nikolas
Copy link
Member

nikolas commented Oct 22, 2019

Your patch here looks good. That's what I would've done to fix this problem.

@Nik-mmzd
Copy link

Not only up/down and not only in the console
Can't move cursor in text fields with home/end (latest git build; sdl2)
Should I open separate issue for this?

@nikolas
Copy link
Member

nikolas commented Oct 25, 2019

No need to open a separate issue, we'll probably just have to add the home and end keys to the list here as well: JGRennison/OpenTTD-patches@299becb

nikolas added a commit to nikolas/OpenTTD that referenced this issue Nov 1, 2019
@nikolas
Fix OpenTTD#7784: up/down/home/end key behavior in SDL2
909ef83 
Closes OpenTTD#7784.
@nikolas nikolas mentioned this issue Nov 1, 2019
Merged
nielsmh pushed a commit that referenced this issue Nov 1, 2019
@nikolas @nielsmh
Fix #7784: up/down/home/end key behavior in SDL2
4884dca 
Closes #7784.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@nikolas @douiwby
Fix OpenTTD#7784: up/down/home/end key behavior in SDL2
ce01213 
Closes OpenTTD#7784.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7784: up/down/home/end key behavior in SDL2 nikolas/OpenTTD
3 participants
@nikolas @JGRennison @Nik-mmzd