Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: inherit yarn2nix from yarn2nix-moretea #71468

Merged
merged 1 commit into from Nov 24, 2019
Merged

tree-wide: inherit yarn2nix from yarn2nix-moretea #71468

merged 1 commit into from Nov 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2019 •
edited by ghost

Motivation for this change

There are a few reasons for doing this:

  • It's unintuitive that you have do to "nix-shell -p yarn2nix-moretea.yarn2nix" to get yarn2nix
  • The other project using this name has not been updated in months and is not currently used anywhere in nixpkgs
  • The yarn2nix command line program is not currently built by Hydra because it does not recurse into the pkgs.yarn2nix-moretea attribute set, which is very annoying. (could also be fixed by enabling recursion for this)

The yarn2nix-moretea attribute set is still left in the tree for easy overriding with custom yarn/nodejs versions.
These changes should not change any derivations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais

@ghost
Copy link
Author

ghost commented Oct 20, 2019

I'm not sure if it is a problem that ofborg is failing in this case.

@Lassulus
Copy link
Member

can you rebase? I will have a look then

@ghost
Copy link
Author

ghost commented Oct 23, 2019 •
edited by ghost

can you rebase? I will have a look then

I have rebased on current master

@Lassulus
Copy link
Member

So, I'm running into the same errors as ofborg. I will try to have a better look tomorrow

@ghost
Copy link
Author

ghost commented Nov 22, 2019

Any news on this? Can someone else take a look maybe?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/82

@ghost
Copy link
Author

ghost commented Nov 23, 2019

Inheriting yarn2nix into the top-level attribute set triggered an IFD-ish issue when building yarn2nix in restricted mode that was fixed in #73911, so rebasing to current master made OfBorg happy :-)

@ghost
Copy link
Author

ghost commented Nov 23, 2019

I added back the nodejs 10.x pinning for codimd, since it was requested.

Lassulus
Lassulus approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues are gone now, LGTM otherwise

@Lassulus Lassulus merged commit 7e0127e into NixOS:master Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lassulus @nixos-discourse