Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t install rust-docs, rust-src, or clippy on CI #24511

Merged
merged 1 commit into from Oct 22, 2019
Merged

Don’t install rust-docs, rust-src, or clippy on CI #24511

merged 1 commit into from Oct 22, 2019

Conversation

SimonSapin
Copy link
Member

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2019
@SimonSapin
Copy link
Member Author

@bors-servo try

bors-servo pushed a commit that referenced this pull request Oct 20, 2019
Auto merge of #24511 - servo:minimal, r=<try>
7c7c16b 
Don’t install rust-docs, rust-src, or clippy on CI

See https://blog.rust-lang.org/2019/10/15/Rustup-1.20.0.html#profiles
@bors-servo
Copy link
Contributor

⌛ Trying commit 76f8f75 with merge 7c7c16b...

@SimonSapin
Copy link
Member Author

Alright, managed to observe the desired behavior on Windows, macOS, and Linux. This PR should be good now.

In my first attempt nothing happened on macOS because the worker already had that version of Rust Nightly installed, so I wanted to have a look at what’s on each server:

% for i in $(seq 1 7); ssh -o 'BatchMode=yes' servo-tc-mac$i.servo.org du -sh /Users/worker/.rustup/toolchains
 21G	/Users/worker/.rustup/toolchains
 21G	/Users/worker/.rustup/toolchains
root@servo-tc-mac3.servo.org: Permission denied (publickey,password,keyboard-interactive).
root@servo-tc-mac4.servo.org: Permission denied (publickey,password,keyboard-interactive).
root@servo-tc-mac5.servo.org: Permission denied (publickey,password,keyboard-interactive).
root@servo-tc-mac6.servo.org: Permission denied (publickey,password,keyboard-interactive).
root@servo-tc-mac7.servo.org: Permission denied (publickey,password,keyboard-interactive).

I expected each worker to have my key configured through salt. @jdm, are workers to 3 to 7 configured differently?

@jdm
Copy link
Member

jdm commented Oct 21, 2019 •
edited

Looks like those workers had never been salted since the ssh key changes. I've deployed to all of them now.

@jdm
Copy link
Member

jdm commented Oct 21, 2019

Does this have any impact on our code that tries to merge the standard library docs with our project docs?

@SimonSapin
Copy link
Member Author

Oh that’s a good point. That task likely needs rustup component add rust-docs or similar. I’ll add it.

@SimonSapin
Copy link
Member Author

https://tools.taskcluster.net/groups/fRGfWK7SQze62WwLbxe1PA/tasks/T6SB8V5eS3u0ZwfpH08wZw/runs/0/logs/public%2Flogs%2Flive.log#L2530 ran without error, I wonder if it copied an empty directory.

@SimonSapin
Copy link
Member Author

Ah, foiled again by ~/.rustup being cached on workers. Here is a proper before and after, with the fix now in this PR.

Looks like those workers had never been salted since the ssh key changes.

My key hasn’t changed in a couple years, though? Trying again now, I can access all macOS workers except # 2 and 9.

@jdm
Copy link
Member

jdm commented Oct 21, 2019

There is no worker 9. I missed 2; I have now deployed the keys to that worker.

@SimonSapin
Copy link
Member Author

Our Macstadium account shows 9 machines, and servo-tc-mac9.servo.org resolves to the corresponding IP address. Anyway, I’ve filed #24520.

This PR is ready for review.

@nox
Copy link
Contributor

nox commented Oct 22, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 6913ad0 has been approved by nox

@highfive highfive assigned nox and unassigned jdm Oct 22, 2019
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 22, 2019
@bors-servo
Copy link
Contributor

⌛ Testing commit 6913ad0 with merge 75830b7...

bors-servo pushed a commit that referenced this pull request Oct 22, 2019
Auto merge of #24511 - servo:minimal, r=nox
75830b7 
Don’t install rust-docs, rust-src, or clippy on CI

See https://blog.rust-lang.org/2019/10/15/Rustup-1.20.0.html#profiles
@bors-servo
Copy link
Contributor

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: nox
Pushing 75830b7 to master...

@bors-servo bors-servo merged commit 6913ad0 into master Oct 22, 2019
@bors-servo bors-servo deleted the minimal branch October 22, 2019 11:56
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SimonSapin @bors-servo @jdm @nox @highfive