Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes 19.09: removal of non-LTS kernel attrs #71397

Merged
merged 2 commits into from Oct 20, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

Even though the release obviously already happened, I think it might
still make sense to add a short note about the attributes not being
supported any longer (and going forward).

Related to: #70202

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais @grahamc @samueldr @NeQuissimus

Even though the release obviously already happened, I think it might
still make sense to add a short note about the attributes not being
supported any longer (and going forward).
@worldofpeace
Copy link
Contributor

This is good to add for sure, I think this was confusing already to a lot of people. Even if it was documented to be this way and it wasn't.

@NeQuissimus NeQuissimus merged commit 9ff6916 into NixOS:release-19.09 Oct 20, 2019
@d-goldin
Copy link
Contributor Author

@NeQuissimus: Thanks! Could you please also take care of throwing this one on master too, so that we don't get inconsistencies with future releases of the manual?

@d-goldin d-goldin deleted the kernel_attrs_releasenotes branch October 20, 2019 16:51
@worldofpeace
Copy link
Contributor

Forward ported in a16de39 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants