Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/gitlab: properly clear out initializers" #71321

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Revert "nixos/gitlab: properly clear out initializers" #71321

merged 1 commit into from
Oct 20, 2019
+1 −1

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 18, 2019 •
edited
Loading

Motivation for this change

This reverts commit 2ee14c3.

This caused the initializers directory to be cleaned out while gitlab
was running in some instances. We clean out the directory on the
preStart stage already, so ensuring existance and permissions should
suffice.

This is a port of #71319 for release-19.09.

Things done

Tested running the following before and after:

systemd-tmpfiles --remove
sudo -u gitlab gitlab-rake gitlab:backup:create RAILS_ENV=production
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @fpletz @flokli @petabyteboy

Sorry, something went wrong.

@talyz
Revert "nixos/gitlab: properly clear out initializers"

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
GPG key ID: 9F6A681E35EF8B56
Verified
Learn about vigilant mode
4d0a45c 
This reverts commit 2ee14c3.

This caused the initializers directory to be cleaned out while gitlab
was running in some instances. We clean out the directory on the
preStart stage already, so ensuring existance and permissions should
suffice.

(cherry picked from commit 201cca9)
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 18, 2019
@flokli flokli merged commit 5907393 into NixOS:release-19.09 Oct 20, 2019
@flokli
Copy link
Contributor

flokli commented Oct 20, 2019

Thanks!

@talyz talyz deleted the gitlab-revert-clear-out-initializers-release-19.09 branch June 16, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @flokli