Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/gitlab: properly clear out initializers" #71319

Merged
merged 1 commit into from Oct 20, 2019
Merged

Revert "nixos/gitlab: properly clear out initializers" #71319

merged 1 commit into from Oct 20, 2019

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Oct 18, 2019

Motivation for this change

This reverts commit 2ee14c3.

This caused the initializers directory to be cleaned out while gitlab
was running in some instances. We clean out the directory on the
preStart stage already, so ensuring existance and permissions should
suffice.

Fixes #71124

Things done

Tested running the following before and after:

systemd-tmpfiles --remove
sudo -u gitlab gitlab-rake gitlab:backup:create RAILS_ENV=production
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @fpletz @flokli @petabyteboy

@talyz
Revert "nixos/gitlab: properly clear out initializers"
201cca9 
This reverts commit 2ee14c3.

This caused the initializers directory to be cleaned out while gitlab
was running in some instances. We clean out the directory on the
preStart stage already, so ensuring existance and permissions should
suffice.
@talyz talyz mentioned this pull request Oct 18, 2019
Merged
10 tasks
@ghost
Copy link

ghost commented Oct 18, 2019

I can confirm this fixes #71124 for me. Thanks!

@flokli flokli merged commit 0a4373a into NixOS:master Oct 20, 2019
@flokli
Copy link
Contributor

flokli commented Oct 20, 2019

Thanks!

@talyz talyz deleted the gitlab-revert-clear-out-initializers branch June 16, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitLab backups fail
2 participants
@talyz @flokli