Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automake-1.15: deterministic date in generated documentation #71346

Merged
merged 1 commit into from Nov 3, 2019
Merged

automake-1.15: deterministic date in generated documentation #71346

merged 1 commit into from Nov 3, 2019

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Oct 18, 2019 •
edited

Motivation for this change

automake 1.15 uses a bundled version of help2man from 2012 that does not support the SOURCE_DATE_EPOCH environment variable.

This means that the build date is included in the generated documentation, breaking reproducibility (see here, here, and here).

This change adds the SOURCE_DATE_EPOCH support from the current help2man to the version bundled in automake 1.15.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d-xo d-xo changed the title automake-1.15: support SOURCE_DATE_EPOCH in help2man automake-1.15: deterministic date in generated documentation Oct 18, 2019
@d-xo
automake-1.15: deterministic documentation generation
832b32b 
automake 1.15 uses a bundled version of help2man from 2012 that
does not support the SOURCE_DATE_EPOCH environment variable.

This means that the build date is included in the generated
documentation, breaking reproducibility.

This changes adds the SOURCE_DATE_EPOCH support from the current
help2man to the version bundled in automake 1.15.
@FRidh FRidh requested a review from vcunat October 22, 2019 07:35
@FRidh
Copy link
Member

FRidh commented Oct 22, 2019

@GrahamcOfBorg build automake

@Lassulus
Copy link
Member

should this happen on staging or master?

@FRidh FRidh changed the base branch from master to staging October 23, 2019 13:49
@FRidh FRidh added this to Needs review in Staging Oct 27, 2019
@FRidh FRidh merged commit cd87f1b into NixOS:staging Nov 3, 2019
Staging automation moved this from Needs review to Done Nov 3, 2019
@d-xo d-xo deleted the reproducible-automake-115 branch November 6, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: reproducible builds 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-xo @FRidh @Lassulus @joachifm