Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.cryptography: 2.7 -> 2.8 #71352

Merged
merged 1 commit into from Oct 20, 2019
Merged

python37Packages.cryptography: 2.7 -> 2.8 #71352

merged 1 commit into from Oct 20, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 18, 2019

Changelog:
https://cryptography.io/en/latest/changelog/#v2-8

Important changes:

  • Deprecated support for OpenSSL 1.0.1. Support will be removed in
    cryptography 2.9.
  • cryptography no longer depends on asn1crypto.
  • Added support for Python 3.8.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Ran a few simple scripts.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos
python37Packages.cryptography: 2.7 -> 2.8
b1c72a7 
Changelog:
https://cryptography.io/en/latest/changelog/#v2-8

Important changes:
- Deprecated support for OpenSSL 1.0.1. Support will be removed in
  cryptography 2.9.
- cryptography no longer depends on asn1crypto.
- Added support for Python 3.8.
@primeos primeos requested a review from FRidh as a code owner October 18, 2019 17:37
@FRidh FRidh merged commit baf5494 into NixOS:staging Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @FRidh