Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graalvm: Use lib.getVersion for stdenv.cc #71472

Merged
merged 1 commit into from Nov 7, 2019
Merged

graalvm: Use lib.getVersion for stdenv.cc #71472

merged 1 commit into from Nov 7, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Oct 20, 2019

Attempting to address fix #71471;

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl veprbl requested review from hlolli and volth October 21, 2019 01:05
@hlolli
Copy link
Member

hlolli commented Oct 21, 2019

It would of course be great if this could work for darwin. I have a darwin myself which I use for ios dev. I'm going to bump this derivation this week, and in the process test darwin. I may want to add, that building graalvm from sources is super memory consuming and slow process. So all help appreciated.

@hlolli
Copy link
Member

hlolli commented Oct 22, 2019

Very nice, I'll try this, thanks!

@matthewbauer matthewbauer merged commit 90e5be0 into NixOS:master Nov 7, 2019
@matthewbauer
Copy link
Member

lib.getVersion should be preferred over .version regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlolli hlolli Awaiting requested review from hlolli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graalvm: build error
3 participants
@regadas @hlolli @matthewbauer