Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update home-assistant-frontend to correct version for home-assistant 0.99.2 #71400

Merged
merged 2 commits into from Oct 20, 2019
Merged

update home-assistant-frontend to correct version for home-assistant 0.99.2 #71400

merged 2 commits into from Oct 20, 2019

Conversation

sweber83
Copy link
Contributor

Motivation for this change

Currently the version of home-assistant-frontend is out of sync with the main home-assistant package.
Because of this some functionality (like the developer tools) of home assistant is broken.

Things done

To fix things bump home-assistant-frontend to 20190919.0
Here one can see that this is the correct version: https://github.com/home-assistant/home-assistant/blob/0.99.2/homeassistant/components/frontend/manifest.json

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fleaz @dotlambda @globin

@risicle
Copy link
Contributor

risicle commented Oct 20, 2019

nix-review is happy for me on macos 10.13.

@etu etu merged commit 463eb7d into NixOS:master Oct 20, 2019
@etu
Copy link
Contributor

etu commented Oct 20, 2019

@sweber83 Thanks! :)

globin added a commit that referenced this pull request Oct 21, 2019
@globin
home-assistant: 2019051.0 -> 20190719.0
97fc74f 
Fixes compatibility with current home-assistant.

See #71400
@globin
Copy link
Member

globin commented Oct 21, 2019

Fixed similarly on 19.09 in 97fc74f

@waldheinz waldheinz mentioned this pull request Oct 21, 2019
Closed
@sweber83
Copy link
Contributor Author

@etu
You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sweber83 @risicle @etu @globin @Janik-Haag