Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediawiki: 1.33.0 -> 1.33.1 #71369

Merged
merged 1 commit into from Oct 20, 2019
Merged

mediawiki: 1.33.0 -> 1.33.1 #71369

merged 1 commit into from Oct 20, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Oct 18, 2019 •
edited

Motivation for this change

https://lists.wikimedia.org/pipermail/mediawiki-announce/2019-October/000236.html
https://www.mediawiki.org/wiki/Release_notes/1.33#Changes_since_MediaWiki_1.33.0

@redvers this is a security release so please cherry pick this commit into a new PR targeting release-19.09.

ping @samueldr (just in case, FYI)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @redvers

@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 18, 2019
@aanderse
Copy link
Member Author

@GrahamcOfBorg test mediawiki

@ofborg ofborg bot requested a review from redvers October 18, 2019 23:40
tomberek
tomberek approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine. Fairly simple bump.

@redvers
Copy link
Member

redvers commented Oct 20, 2019

@aanderse - will do.

redvers
redvers approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@redvers redvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be cherrypicking to stable momentarily.

@aanderse aanderse merged commit c7e1fde into NixOS:master Oct 20, 2019
@aanderse aanderse deleted the mediawiki branch October 20, 2019 01:10
@redvers redvers mentioned this pull request Oct 20, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@redvers redvers redvers approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @redvers @tomberek