Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kazam: fix package #71367

Merged
merged 1 commit into from Oct 18, 2019
Merged

kazam: fix package #71367

merged 1 commit into from Oct 18, 2019

Conversation

thorstenweber83
Copy link
Contributor

Since @worldofpeace already presented all necessary pieces in #71031 i just put together the pr.

Motivation for this change

make package work again, close issue #71031

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar

@thorstenweber83
kazam: fix
15953b7 
- work around strictDeps issue wit python packages
- use pr 21 commit instead of debian patch to fix configparser issue
@ofborg ofborg bot requested a review from domenkozar October 18, 2019 23:25
worldofpeace
worldofpeace approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for applying my suggestions.

Though tbh, there's applications up-to-date and maintained with just as nice gtk3 ui's and use csd...

@worldofpeace worldofpeace merged commit 9b898ec into NixOS:master Oct 18, 2019
@worldofpeace
Copy link
Contributor

Backported in 4ba1af2

@thorstenweber83 thorstenweber83 deleted the fix-kazam branch October 19, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thorstenweber83 @worldofpeace