Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dhcpcd: 8.0.6 -> 8.1.1 #71365

Merged
merged 1 commit into from Oct 19, 2019
Merged

dhcpcd: 8.0.6 -> 8.1.1 #71365

merged 1 commit into from Oct 19, 2019

Conversation

samhug
Copy link
Contributor

@samhug samhug commented Oct 18, 2019 •
edited by jonringer

https://roy.marples.name/blog/dhcpcd-8-1-1-released

I've been running this locally for a couple of days now with no problems.
It fixed an issue for me where dhcpcd was core dumping multiple times a day.

I ran the nixos.tests.networking.scripted.macvlan.x86_64-linux test specified in the comment and it passed for me.

I don't know if there are important implications to upgrading this for other people so feedback is welcome.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eelco @fpletz

@ofborg ofborg bot requested review from fpletz and edolstra October 18, 2019 22:51
@samhug
Copy link
Contributor Author

samhug commented Oct 18, 2019

@eelco sorry for the spam. I just realized I tagged the wrong person.

@jonringer
Copy link
Contributor

@GrahamcOfBorg test networking.scripted

@jonringer
Copy link
Contributor

@GrahamcOfBorg build dhcpcd pipework wicd

@jonringer jonringer merged commit 552e55a into NixOS:master Oct 19, 2019
@samhug samhug deleted the dhcpcd-8.1.1 branch October 19, 2019 16:14
@Izorkin
Copy link
Contributor

Izorkin commented Oct 19, 2019

After this update, an error update to the lease of the IP address occurs on the virtual server.

@jonringer
Copy link
Contributor

interesting... seemed to pass locally

@Izorkin
Copy link
Contributor

Izorkin commented Oct 19, 2019 

окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: DAD completed for 192.168.122.123
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: leased 192.168.122.123 for 3600 seconds
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: renew in 1800 seconds, rebind in 3150 seconds
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: writing lease `/var/db/dhcpcd/eth1.lease'
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: adding IP address 192.168.122.123/24 broadcast 192.168.122.255
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: adding route to 192.168.122.0/24
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: adding default route via 192.168.122.1
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: ARP announcing 192.168.122.123 (1 of 2), next in 2.0 seconds
окт 19 21:42:56 <HOST> dhcpcd[64435]: eth1: executing `/nix/store/494rdi0fi3mvvp1kz4a2kv58j6mwr73g-dhcpcd-8.1.1/libexec/dhcpcd-run-hooks' BOUND
окт 19 21:42:57 <HOST> dhcpcd[64435]: eth0: ARP announcing 192.168.248.201 (2 of 2)
окт 19 21:42:58 <HOST> dhcpcd[64435]: eth1: ARP announcing 192.168.122.123 (2 of 2)

окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: renewing lease of 192.168.248.201
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: sending REQUEST (xid 0x40199f83), next in 4.1 seconds
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: acknowledged 192.168.248.201 from 192.168.248.1
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: leased 192.168.248.201 for 3600 seconds
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: renew in 1800 seconds, rebind in 3150 seconds
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: writing lease `/var/db/dhcpcd/eth0.lease'
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: adding IP address 192.168.248.201/24 broadcast 192.168.248.255
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: ARP announcing 192.168.248.201 (1 of 2), next in 2.0 seconds
окт 19 22:12:55 <HOST> dhcpcd[64435]: eth0: executing `/nix/store/494rdi0fi3mvvp1kz4a2kv58j6mwr73g-dhcpcd-8.1.1/libexec/dhcpcd-run-hooks' RENEW
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: renewing lease of 192.168.122.123
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: sending REQUEST (xid 0x45d16c7), next in 3.9 seconds
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: acknowledged 192.168.122.123 from 192.168.122.1
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: leased 192.168.122.123 for 3600 seconds
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: renew in 1611 seconds, rebind in 2961 seconds
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: writing lease `/var/db/dhcpcd/eth1.lease'
окт 19 22:12:56 <HOST> dhcpcd[64435]: eth1: adding IP address 192.168.122.123/24 broadcast 192.168.122.255

after that there is nothing in the logs, and the server stops receiving the ip address

@yorickvP
Copy link
Contributor

This causes my dhcpcd to get stuck and use 100% cpu occasionally when switching networks.

@fpletz
Copy link
Member

fpletz commented Oct 30, 2019

Some of our laptop users on master experienced similar issues. It would be nice to have a NixOS test for this issue but it doesn't seem to be reproducible, at least in the field.

Shall we revert for now?

@yorickvP
Copy link
Contributor

void-linux/void-packages#15885

@yorickvP
Copy link
Contributor

@fpletz reverting sounds good, if the core dumps are an issue we can go back to 7.2.2 too

@yorickvP
Copy link
Contributor

https://roy.marples.name/archives/dhcpcd-discuss/0002668.html

@jonringer
Copy link
Contributor

I didn't seem to have any issues, but if it's effecting others then I'm' in favor of reverting

fpletz added a commit that referenced this pull request Oct 30, 2019
@fpletz
Revert "dhcpcd: 8.0.6 -> 8.1.1"
23f3abd 
This reverts commit 1c62094.

See discussion in #71365.
@fpletz
Copy link
Member

fpletz commented Oct 30, 2019

Reverted in 23f3abd.

@jonringer
Copy link
Contributor

jonringer commented Oct 30, 2019 •
edited

I apologize if this inconvenienced anyone :(

@Kiwi
Copy link
Member

Kiwi commented Oct 31, 2019 •
edited

This might be related, I think it's the same problem or at least this change the reason. I have had a lot of problems lately with WiFi on nixos-unstable (and/or 19.09) and some (possibly the only problem was dhcpcd, but I think I had multiple issues and it was only one) of them were definitely related to dhcpcd. The logs I have are quite similar to the ones above. I've been watching on IRC and know of probably something like 6 or more people that have only recently had problems. In most of the cases disabling with networking.dhcpcd.enable = false; was enough. I don't know that all of us use network manager but it seems more likely correlated than not. I saw at least one person that was using iwd with dhcpcd related problems, too.

I don't know if that's helpful but maybe it will help someone figure out what's going wrong. Or at least see how to disable it if they somehow end up getting it before the revert goes through or w/e. I can provide additional log files by request if that would be of use.

@yorickvP
Copy link
Contributor

yorickvP commented Nov 1, 2019

It's being worked on in NetworkConfiguration/dhcpcd#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samhug @jonringer @Izorkin @yorickvP @fpletz @Kiwi