Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordpress: 5.2.3 -> 5.2.4 #71368

Merged
merged 1 commit into from Oct 22, 2019
Merged

wordpress: 5.2.3 -> 5.2.4 #71368

merged 1 commit into from Oct 22, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change

https://wordpress.org/news/2019/10/wordpress-5-2-4-security-release/

@FPtje or @mmilata would either (or both) of you be willing to take ownership of this package? I would guess there is a high chance @basvandijk is no longer interested in maintaining. If we are to have wordpress in nixos I suggest we be very consistent on staying current with security updates, and back-porting them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse aanderse added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 18, 2019
@aanderse
Copy link
Member Author

@GrahamcOfBorg test wordpress

@ofborg ofborg bot requested a review from basvandijk October 18, 2019 23:27
tomberek
tomberek approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple bump, builds fine.

@aanderse aanderse merged commit 5c1d4ed into NixOS:master Oct 22, 2019
@aanderse aanderse deleted the wordpress branch October 22, 2019 01:19
@aanderse aanderse mentioned this pull request Oct 22, 2019
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @tomberek @c0bw3b @TredwellGit