Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundcube: fix -- quoting string env variable #71407

Merged
merged 4 commits into from Nov 20, 2019
Merged

roundcube: fix -- quoting string env variable #71407

merged 4 commits into from Nov 20, 2019

Conversation

f--t
Copy link
Contributor

@f--t f--t commented Oct 19, 2019

Motivation for this change

fix the env variable for the case postgresql password contains spaces.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

DinCahill
DinCahill suggested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@DinCahill DinCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a PR on your branch to update the test to show this works. https://github.com/f--t/nixpkgs/pull/1

@DinCahill
Copy link
Contributor

Notifying maintainers @Vskilet @globin

@f--t
Merge pull request #1 from DinCahill/fix/roundcube
d7982b7 
roundcube: tests - add space to db password, check setup script worked
@f--t
Merge branch 'master' into fix/roundcube
4c18309
@globin
Copy link
Member

globin commented Nov 20, 2019

Hmm should still be quoted properly but better than before at least

@globin globin merged commit 5f7bcff into NixOS:master Nov 20, 2019
Ma27 added a commit that referenced this pull request Nov 22, 2019
@Ma27
roundcube: 1.4.0 -> 1.4.1
e292be7 
https://github.com/roundcube/roundcubemail/releases/tag/1.4.1

Also fixed the test which got broken during #71407, most likely due to a
merge issue.
Vskilet pushed a commit to Vskilet/nixpkgs that referenced this pull request Dec 6, 2019
@Ma27 @Vskilet
roundcube: 1.4.0 -> 1.4.1
a9edcd4 
https://github.com/roundcube/roundcubemail/releases/tag/1.4.1

Also fixed the test which got broken during NixOS#71407, most likely due to a
merge issue.
@f--t f--t deleted the fix/roundcube branch August 21, 2022 23:13
@f--t f--t restored the fix/roundcube branch August 21, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinCahill DinCahill DinCahill requested changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f--t @DinCahill @globin