Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectd: plugins configuration, buildMinimalPackage #71406

Merged
merged 4 commits into from
Oct 21, 2019
Merged

collectd: plugins configuration, buildMinimalPackage #71406

merged 4 commits into from
Oct 21, 2019
+392 −57

Conversation

astro
Copy link
Contributor

@astro astro commented Oct 19, 2019

Motivation for this change

Allows configuration of collectd plugins in services.collectd.plugins.

Using this set of desired plugins, the user can now enable services.collectd.buildMinimalPackage to build only these plugins. This way is more obvious to users compared to overriding the packages input set with null values.

This feature is optional and backwards compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bjornfor @fpletz

Sorry, something went wrong.

@astro astro changed the title collectd: buildMinimalPackage collectd: plugins configuration, buildMinimalPackage Oct 19, 2019
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 19, 2019
@ofborg ofborg bot requested review from fpletz and bjornfor October 19, 2019 23:18
fpletz
fpletz approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@fpletz fpletz merged commit cc9b18f into NixOS:master Oct 21, 2019
@astro astro deleted the collectd branch October 21, 2019 12:22
@astro astro mentioned this pull request Aug 16, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@bjornfor bjornfor

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @fpletz @bjornfor