Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 639a0eafcb3c
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a13b8ce0b80d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Oct 14, 2019

  1. nixos/plymouth: do not order plymouth-quit after display-manager

    GDM now specifies ordering between `plymouth-quit` and `display-manager`:
    9be5321
    
    This causes an ordering cycle between GDM and plymouth-quit which can result in
    systemd breaking GDM:
    ```
    plymouth-quit.service: Job display-manager.service/start deleted to break
                           ordering cycle starting with plymouth-quit.service/start
    ```
    
    Not sure how often this triggers, as I've run my system with plymouth and
    9be5321 without any issues. But I did catch a VM doing this.
    
    NOTE: I also tried to remove the ordering in GDM to see if plymouth managed to
    live longer, but it didn't seem to help. So I opted to stick as close to
    upstream (upstream GDM specifies ordering, but plymouth does not).
    hedning committed Oct 14, 2019
    Copy the full SHA
    5924bab View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Merge pull request #71115 from hedning/plymouth-gdm-fix

    nixos/plymouth: do not order `plymouth-quit` after `display-manager`
    worldofpeace committed Oct 19, 2019
    Copy the full SHA
    a13b8ce View commit details
    Browse the repository at this point in the history