Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boulder: init at release-2019-10-13 #71324

Closed
wants to merge 1 commit into from
Closed

boulder: init at release-2019-10-13 #71324

wants to merge 1 commit into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 18, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@adisbladis adisbladis mentioned this pull request Oct 18, 2019
Merged
10 tasks
@picnoir
Copy link
Member

picnoir commented Oct 18, 2019 •
edited

Thanks!

Several patches are applied to the current boulder derivation ( https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/common/letsencrypt/default.nix#L153 ). Are those patches obsolete?

cc @aszlig who wrote the original boulder derivation.

@adisbladis
Copy link
Member Author

@NinjaTrappeur We might want to add https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/common/letsencrypt/default.nix#L167 as an override in the test file itself.

We may also need to add sources to $out. cc @aszlig

c0bw3b
c0bw3b reviewed Oct 18, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -10518,6 +10518,8 @@ in
botan = callPackage ../development/libraries/botan { openssl = openssl_1_0_2; };
botan2 = callPackage ../development/libraries/botan/2.0.nix { };

boulder = callPackage ../tools/admin/boulder { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) it should rather be in the ### TOOLS section, between bonfire and buildbot

c0bw3b
c0bw3b reviewed Oct 18, 2019
View reviewed changes
pkgs/tools/admin/boulder/default.nix

meta = {
homepage = "https://github.com/letsencrypt/boulder";
description = "An ACME-based CA, written in Go.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick²)

Suggested change
description = "An ACME-based CA, written in Go.";
description = "An ACME-based CA, written in Go";

As per manual guidelines

picnoir
picnoir approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % the naming nitpicks from @c0bw3b

I'll use this PR as base for #71291

@adisbladis
Copy link
Member Author

@NinjaTrappeur Cool! Shall I close this one?

@adisbladis adisbladis closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@picnoir picnoir picnoir approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @picnoir @c0bw3b