Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: temporarily disable stalled theme genaration #71325

Closed
wants to merge 1 commit into from
Closed

gtk3: temporarily disable stalled theme genaration #71325

wants to merge 1 commit into from

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Oct 18, 2019

Motivation for this change

gtk ships with themes, but supports regenerating them with sassc, unfortunately
libsass-3.6.2 has bug which makes this stall forever.

Note I'm not sure how many other themes (sass/libsass#3006) will break with the newer libsass, so might be better to downgrade that?

cc #71221

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@hedning
gtk3: temporarily disable stalled theme genaration
9889dd2 
gtk ships with themes, but supports regenerating them with sassc, unfortunately
libsass-3.6.2 has bug which makes this stall forever.
@hedning
Copy link
Contributor Author

hedning commented Oct 18, 2019

Ah, libsass was reverted: ddee207

@hedning hedning closed this Oct 18, 2019
@FRidh
Copy link
Member

FRidh commented Oct 18, 2019

Ah, I just reverted libsass bump instead
ddee207

@hedning
Copy link
Contributor Author

hedning commented Oct 18, 2019

Yeah saw 😆, probably better that way, as the newer libsass would probably break a bunch of other themes.

@hedning hedning deleted the fix-gtk3-stalled-build branch March 1, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hedning @FRidh